Changing replica count to up 2 for custom result index #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
============================================
+ Coverage 80.05% 80.12% +0.06%
- Complexity 5669 5680 +11
============================================
Files 533 533
Lines 23430 23434 +4
Branches 2334 2334
============================================
+ Hits 18758 18776 +18
+ Misses 3562 3553 -9
+ Partials 1110 1105 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jackiehanyang
approved these changes
Nov 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 5ec87b2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 5ec87b2) Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing auto expand replica setting for custom result index to 0-2 so we have at least 2 replicas when node count is over 2.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.